[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Thu, 9 Mar 2017 18:17:18 -0500
From: Boris Ostrovsky <boris.ostrovsky@...cle.com>
To: Thomas Garnier <thgarnie@...gle.com>
Cc: Michal Hocko <mhocko@...e.com>, Stanislaw Gruszka <sgruszka@...hat.com>,
kvm list <kvm@...r.kernel.org>,
"linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
Matt Fleming <matt@...eblueprint.co.uk>,
Frederic Weisbecker <fweisbec@...il.com>,
Josh Poimboeuf <jpoimboe@...hat.com>,
Chris Wilson
<chris@...is-wilson.co.uk>,
"linux-mm@...ck.org" <linux-mm@...ck.org>,
Dave Hansen <dave.hansen@...el.com>,
Radim Krčmář
<rkrcmar@...hat.com>,
"linux-efi@...r.kernel.org"
<linux-efi@...r.kernel.org>,
Alexander Potapenko <glider@...gle.com>, Pavel Machek <pavel@....cz>,
"H . Peter Anvin" <hpa@...or.com>,
"kernel-hardening@...ts.openwall.com" <kernel-hardening@...ts.openwall.com>,
Jiri Olsa <jolsa@...hat.com>, zijun_hu <zijun_hu@....com>,
Prarit Bhargava <prarit@...hat.com>, Andi Kleen <ak@...ux.intel.com>,
Len Brown <len.brown@...el.com>, Jonathan Corbet <corbet@....net>,
Michael Ellerman <mpe@...erman.id.au>, Joerg Roedel <joro@...tes.org>,
X86 ML <x86@...nel.org>, "Luis R . Rodriguez" <mcgrof@...nel.org>,
kasan-dev <kasan-dev@...glegroups.com>,
Christian Borntraeger <borntraeger@...ibm.com>,
Ingo Molnar <mingo@...hat.com>,
"xen-devel@...ts.xenproject.org" <xen-devel@...ts.xenproject.org>,
Borislav Petkov <bp@...e.de>, Fenghua Yu <fenghua.yu@...el.com>,
Jiri Kosina <jikos@...nel.org>, Kees Cook <keescook@...omium.org>,
Arnd Bergmann <arnd@...db.de>, He Chen <he.chen@...ux.intel.com>,
Brian Gerst <brgerst@...il.com>, Rusty Russell <rusty@...tcorp.com.au>,
Joonsoo Kim <iamjoonsoo.kim@....com>, lguest@...ts.ozlabs.org,
Andy Lutomirski <luto@...nel.org>,
Andrey Ryabinin
<aryabinin@...tuozzo.com>,
Thomas Gleixner <tglx@...utronix.de>,
Andrew Morton <akpm@...ux-foundation.org>,
Dmitry Vyukov
<dvyukov@...gle.com>, Juergen Gross <jgross@...e.com>,
Lorenzo Stoakes <lstoakes@...il.com>,
Paul Gortmaker <paul.gortmaker@...driver.com>,
Andrew Cooper <andrew.cooper3@...rix.com>,
"linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
Ard Biesheuvel <ard.biesheuvel@...aro.org>,
"Rafael J . Wysocki" <rjw@...ysocki.net>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
Andy Lutomirski <luto@...capital.net>,
Peter Zijlstra
<peterz@...radead.org>,
Paolo Bonzini <pbonzini@...hat.com>,
Vitaly Kuznetsov <vkuznets@...hat.com>,
Tim Chen <tim.c.chen@...ux.intel.com>
Subject: Re: [Xen-devel] [PATCH v5 2/3] x86: Remap GDT tables in the Fixmap
section
On 03/09/2017 05:31 PM, Thomas Garnier wrote:
> On Thu, Mar 9, 2017 at 2:13 PM, Boris Ostrovsky
> <boris.ostrovsky@...cle.com> wrote:
>>>> I don't have any experience with Xen so it would be great if virtme can test it.
>>> I am pretty sure I tested this series at some point but I'll test it again.
>>>
>>
>> Fails 32-bit build:
>>
>>
>> /home/build/linux-boris/arch/x86/kvm/vmx.c: In function ‘segment_base’:
>> /home/build/linux-boris/arch/x86/kvm/vmx.c:2054: error: ‘host_gdt’
>> undeclared (first use in this function)
>> /home/build/linux-boris/arch/x86/kvm/vmx.c:2054: error: (Each undeclared
>> identifier is reported only once
>> /home/build/linux-boris/arch/x86/kvm/vmx.c:2054: error: for each
>> function it appears in.)
>> /home/build/linux-boris/arch/x86/kvm/vmx.c:2054: error: type defaults to
>> ‘int’ in declaration of ‘type name’
>> /home/build/linux-boris/arch/x86/kvm/vmx.c:2054: error: type defaults to
>> ‘int’ in declaration of ‘type name’
>> /home/build/linux-boris/arch/x86/kvm/vmx.c:2054: warning: initialization
>> from incompatible pointer type
>> /home/build/linux-boris/arch/x86/kvm/vmx.c:2054: warning: unused
>> variable ‘gdt’
>>
>>
>> -boris
> It seems that I forgot to remove line 2054 on the rebase. My 32-bit
> build comes clean but I assume it is not good enough compare to the
> full version I build for 64-bit KVM testing.
>
> Remove just this line and it should build fine, I will fix this on the
> next iteration.
>
> Thanks for testing,
>
So this, in fact, does break Xen in that the hypercall to set GDT fails.
I will have lo look at this tomorrow but I definitely at least built
with v3 of this series. And I don't see why I wouldn't have tested it
once I built it.
-boris
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
