Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date: Tue, 14 Feb 2017 08:30:25 -0700
From: Jens Axboe <axboe@...nel.dk>
To: Kees Cook <keescook@...omium.org>, linux-kernel@...r.kernel.org
Cc: Jonathan Corbet <corbet@....net>, Tim Waugh <tim@...erelk.net>,
 Borislav Petkov <bp@...en8.de>, "David S. Miller" <davem@...emloft.net>,
 "James E.J. Bottomley" <jejb@...ux.vnet.ibm.com>,
 "Martin K. Petersen" <martin.petersen@...cle.com>,
 linux-doc@...r.kernel.org, linux-ide@...r.kernel.org,
 linux-scsi@...r.kernel.org, kernel-hardening@...ts.openwall.com
Subject: Re: [PATCH] cdrom: Make device operations read-only

On 02/13/2017 05:25 PM, Kees Cook wrote:
> Since function tables are a common target for attackers, it's best to keep
> them in read-only memory. As such, this makes the CDROM device ops tables
> const. This drops additionally n_minors, since it isn't used meaningfully,
> and sets the only user of cdrom_dummy_generic_packet explicitly so the
> variables can all be const.

Agree, it's a good change. Applied for 4.11.

-- 
Jens Axboe

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.