[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Tue, 29 Mar 2016 09:35:40 -0600
From: Shuah Khan <shuahkh@....samsung.com>
To: Kees Cook <keescook@...omium.org>, Mickaël Salaün
<mic@...ikod.net>
Cc: linux-security-module <linux-security-module@...r.kernel.org>,
Andreas Gruenbacher <agruenba@...hat.com>,
Andy Lutomirski <luto@...capital.net>, Andy Lutomirski <luto@...nel.org>,
Arnd Bergmann <arnd@...db.de>, Casey Schaufler <casey@...aufler-ca.com>,
Daniel Borkmann <daniel@...earbox.net>, David Drysdale
<drysdale@...gle.com>, Eric Paris <eparis@...hat.com>,
James Morris <james.l.morris@...cle.com>, Jeff Dike <jdike@...toit.com>,
Julien Tinnes <jln@...gle.com>, Michael Kerrisk <mtk@...7.org>,
Paul Moore <pmoore@...hat.com>, Richard Weinberger <richard@....at>,
"Serge E . Hallyn" <serge@...lyn.com>, Stephen Smalley <sds@...ho.nsa.gov>,
Tetsuo Handa <penguin-kernel@...ove.sakura.ne.jp>,
Will Drewry <wad@...omium.org>, Linux API <linux-api@...r.kernel.org>,
"kernel-hardening@...ts.openwall.com" <kernel-hardening@...ts.openwall.com>,
Shuah Khan <shuahkh@....samsung.com>
Subject: Re: [RFC v1 03/17] selftest/seccomp: Fix the flag name
SECCOMP_FILTER_FLAG_TSYNC
On 03/23/2016 10:35 PM, Kees Cook wrote:
> On Wed, Mar 23, 2016 at 6:46 PM, Mickaël Salaün <mic@...ikod.net> wrote:
>> Rename SECCOMP_FLAG_FILTER_TSYNC to SECCOMP_FILTER_FLAG_TSYNC to match
>> the UAPI.
>>
>> Signed-off-by: Mickaël Salaün <mic@...ikod.net>
>> Cc: Kees Cook <keescook@...omium.org>
>> Cc: Andy Lutomirski <luto@...capital.net>
>> Cc: Will Drewry <wad@...omium.org>
>
> Hah, oops. Thanks! Shuah, can you take this patch into the selftest tree?
>
> Acked-by: Kees Cook <keescook@...omium.org>
>
Hi Michael,
Could you please send me the patch. I can't find it in my Inbox. I can get
this into rc-2 with Kees Cook's ack.
thanks,
-- Shuah
>
>> ---
>> tools/testing/selftests/seccomp/seccomp_bpf.c | 18 +++++++++---------
>> 1 file changed, 9 insertions(+), 9 deletions(-)
>>
>> diff --git a/tools/testing/selftests/seccomp/seccomp_bpf.c b/tools/testing/selftests/seccomp/seccomp_bpf.c
>> index b9453b838162..9c1460f277c2 100644
>> --- a/tools/testing/selftests/seccomp/seccomp_bpf.c
>> +++ b/tools/testing/selftests/seccomp/seccomp_bpf.c
>> @@ -1497,8 +1497,8 @@ TEST_F(TRACE_syscall, syscall_dropped)
>> #define SECCOMP_SET_MODE_FILTER 1
>> #endif
>>
>> -#ifndef SECCOMP_FLAG_FILTER_TSYNC
>> -#define SECCOMP_FLAG_FILTER_TSYNC 1
>> +#ifndef SECCOMP_FILTER_FLAG_TSYNC
>> +#define SECCOMP_FILTER_FLAG_TSYNC 1
>> #endif
>>
>> #ifndef seccomp
>> @@ -1613,7 +1613,7 @@ TEST(TSYNC_first)
>> TH_LOG("Kernel does not support PR_SET_NO_NEW_PRIVS!");
>> }
>>
>> - ret = seccomp(SECCOMP_SET_MODE_FILTER, SECCOMP_FLAG_FILTER_TSYNC,
>> + ret = seccomp(SECCOMP_SET_MODE_FILTER, SECCOMP_FILTER_FLAG_TSYNC,
>> &prog);
>> ASSERT_NE(ENOSYS, errno) {
>> TH_LOG("Kernel does not support seccomp syscall!");
>> @@ -1831,7 +1831,7 @@ TEST_F(TSYNC, two_siblings_with_ancestor)
>> self->sibling_count++;
>> }
>>
>> - ret = seccomp(SECCOMP_SET_MODE_FILTER, SECCOMP_FLAG_FILTER_TSYNC,
>> + ret = seccomp(SECCOMP_SET_MODE_FILTER, SECCOMP_FILTER_FLAG_TSYNC,
>> &self->apply_prog);
>> ASSERT_EQ(0, ret) {
>> TH_LOG("Could install filter on all threads!");
>> @@ -1892,7 +1892,7 @@ TEST_F(TSYNC, two_siblings_with_no_filter)
>> TH_LOG("Kernel does not support PR_SET_NO_NEW_PRIVS!");
>> }
>>
>> - ret = seccomp(SECCOMP_SET_MODE_FILTER, SECCOMP_FLAG_FILTER_TSYNC,
>> + ret = seccomp(SECCOMP_SET_MODE_FILTER, SECCOMP_FILTER_FLAG_TSYNC,
>> &self->apply_prog);
>> ASSERT_NE(ENOSYS, errno) {
>> TH_LOG("Kernel does not support seccomp syscall!");
>> @@ -1940,7 +1940,7 @@ TEST_F(TSYNC, two_siblings_with_one_divergence)
>> self->sibling_count++;
>> }
>>
>> - ret = seccomp(SECCOMP_SET_MODE_FILTER, SECCOMP_FLAG_FILTER_TSYNC,
>> + ret = seccomp(SECCOMP_SET_MODE_FILTER, SECCOMP_FILTER_FLAG_TSYNC,
>> &self->apply_prog);
>> ASSERT_EQ(self->sibling[0].system_tid, ret) {
>> TH_LOG("Did not fail on diverged sibling.");
>> @@ -1992,7 +1992,7 @@ TEST_F(TSYNC, two_siblings_not_under_filter)
>> TH_LOG("Kernel does not support SECCOMP_SET_MODE_FILTER!");
>> }
>>
>> - ret = seccomp(SECCOMP_SET_MODE_FILTER, SECCOMP_FLAG_FILTER_TSYNC,
>> + ret = seccomp(SECCOMP_SET_MODE_FILTER, SECCOMP_FILTER_FLAG_TSYNC,
>> &self->apply_prog);
>> ASSERT_EQ(ret, self->sibling[0].system_tid) {
>> TH_LOG("Did not fail on diverged sibling.");
>> @@ -2021,7 +2021,7 @@ TEST_F(TSYNC, two_siblings_not_under_filter)
>> /* Switch to the remaining sibling */
>> sib = !sib;
>>
>> - ret = seccomp(SECCOMP_SET_MODE_FILTER, SECCOMP_FLAG_FILTER_TSYNC,
>> + ret = seccomp(SECCOMP_SET_MODE_FILTER, SECCOMP_FILTER_FLAG_TSYNC,
>> &self->apply_prog);
>> ASSERT_EQ(0, ret) {
>> TH_LOG("Expected the remaining sibling to sync");
>> @@ -2044,7 +2044,7 @@ TEST_F(TSYNC, two_siblings_not_under_filter)
>> while (!kill(self->sibling[sib].system_tid, 0))
>> sleep(0.1);
>>
>> - ret = seccomp(SECCOMP_SET_MODE_FILTER, SECCOMP_FLAG_FILTER_TSYNC,
>> + ret = seccomp(SECCOMP_SET_MODE_FILTER, SECCOMP_FILTER_FLAG_TSYNC,
>> &self->apply_prog);
>> ASSERT_EQ(0, ret); /* just us chickens */
>> }
>> --
>> 2.8.0.rc3
>>
>
>
>
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
