Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date: Thu, 17 Dec 2015 13:55:32 -0800
From: David Brown <david.brown@...aro.org>
To: kernel-hardening@...ts.openwall.com
Cc: David Windsor <dave@...gbits.org>, Kees Cook <keescook@...omium.org>
Subject: Re: [RFC PATCH 5/5] lkdtm: add test for atomic_t
 underflow/overflow

On Thu, Dec 17, 2015 at 12:56:36AM -0500, David Windsor wrote:

>diff --git a/drivers/misc/lkdtm.c b/drivers/misc/lkdtm.c
>index b5abe34..5002747 100644
>--- a/drivers/misc/lkdtm.c
>+++ b/drivers/misc/lkdtm.c
>@@ -104,6 +104,7 @@ enum ctype {
> 	CT_ACCESS_USERSPACE,
> 	CT_WRITE_RO,
> 	CT_WRITE_KERN,
>+    CT_WRAP_ATOMIC
> };
>
> static char* cp_name[] = {

You seem to be indenting with spaces rather than tabs.  It'd probably
be a good idea to run checkpatch on the patches.  It should catch
this.

David

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.