[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Fri, 03 Aug 2012 07:19:55 -0700
From: ebiederm@...ssion.com (Eric W. Biederman)
To: Richard Weinberger <richard@....at>
Cc: linux-kernel@...r.kernel.org, linux-doc@...r.kernel.org, dvhart@...ux.intel.com, paul.gortmaker@...driver.com, jkosina@...e.cz, rob@...dley.net, Randy Dunlap <rdunlap@...otime.net>, Peter Zijlstra <a.p.zijlstra@...llo.nl>, David Howells <dhowells@...hat.com>, "Serge E. Hallyn" <serge.hallyn@...onical.com>, kernel-hardening@...ts.openwall.com, spender@...ecurity.net, keescook@...omium.org, tglx@...utronix.de, Cyrill Gorcunov <gorcunov@...nvz.org>, xemul@...allels.com, <stable@...r.kernel.org>
Subject: Re: [PATCH] Revert "futex: Mark get_robust_list as deprecated"
Richard Weinberger <richard@....at> writes:
> get_robust_list has at least two valid use cases.
> 1. checkpoint/restore in userspace
> 2. post mortem analysis
Looks good to me.
Acked-by: "Eric W. Biederman" <ebiederm@...ssion.com>
>
> Cc: Randy Dunlap <rdunlap@...otime.net>
> Cc: Darren Hart <dvhart@...ux.intel.com>
> Cc: Peter Zijlstra <a.p.zijlstra@...llo.nl>
> Cc: Jiri Kosina <jkosina@...e.cz>
> Cc: Eric W. Biederman <ebiederm@...ssion.com>
> Cc: David Howells <dhowells@...hat.com>
> Cc: Serge E. Hallyn <serge.hallyn@...onical.com>
> Cc: kernel-hardening@...ts.openwall.com
> Cc: spender@...ecurity.net
> Cc: keescook@...omium.org
> Cc: tglx@...utronix.de
> Cc: Cyrill Gorcunov <gorcunov@...nvz.org>
> Cc: xemul@...allels.com
> Cc: <stable@...r.kernel.org> # 3.4.x
> Cc: <stable@...r.kernel.org> # 3.5.x
> Link: http://lkml.kernel.org/r/CAFLxGvzPVPyXPwjay4a01q1vx4K4Ht56bHjzswYrr1wvB_1dYw%20%28%29%20mail%20!%20gmail%20!%20com
> Signed-off-by: Richard Weinberger <richard@....at>
> ---
> Documentation/feature-removal-schedule.txt | 10 ----------
> kernel/futex.c | 2 --
> kernel/futex_compat.c | 2 --
> 3 Dateien geändert, 14 Zeilen entfernt(-)
>
> diff --git a/Documentation/feature-removal-schedule.txt b/Documentation/feature-removal-schedule.txt
> index afaff31..a25482e 100644
> --- a/Documentation/feature-removal-schedule.txt
> +++ b/Documentation/feature-removal-schedule.txt
> @@ -506,16 +506,6 @@ Who: Sebastian Andrzej Siewior <sebastian@...akpoint.cc>
>
> ----------------------------
>
> -What: get_robust_list syscall
> -When: 2013
> -Why: There appear to be no production users of the get_robust_list syscall,
> - and it runs the risk of leaking address locations, allowing the bypass
> - of ASLR. It was only ever intended for debugging, so it should be
> - removed.
> -Who: Kees Cook <keescook@...omium.org>
> -
> -----------------------------
> -
> What: Removing the pn544 raw driver.
> When: 3.6
> Why: With the introduction of the NFC HCI and SHDL kernel layers, pn544.c
> diff --git a/kernel/futex.c b/kernel/futex.c
> index e2b0fb9..d701be5 100644
> --- a/kernel/futex.c
> +++ b/kernel/futex.c
> @@ -2449,8 +2449,6 @@ SYSCALL_DEFINE3(get_robust_list, int, pid,
> if (!futex_cmpxchg_enabled)
> return -ENOSYS;
>
> - WARN_ONCE(1, "deprecated: get_robust_list will be deleted in 2013.\n");
> -
> rcu_read_lock();
>
> ret = -ESRCH;
> diff --git a/kernel/futex_compat.c b/kernel/futex_compat.c
> index 83e368b..a9642d5 100644
> --- a/kernel/futex_compat.c
> +++ b/kernel/futex_compat.c
> @@ -142,8 +142,6 @@ compat_sys_get_robust_list(int pid, compat_uptr_t __user *head_ptr,
> if (!futex_cmpxchg_enabled)
> return -ENOSYS;
>
> - WARN_ONCE(1, "deprecated: get_robust_list will be deleted in 2013.\n");
> -
> rcu_read_lock();
>
> ret = -ESRCH;
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
