Openwall GNU/*/Linux - a small security-enhanced Linux distro for servers
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date: Tue, 15 Nov 2011 16:53:33 +0400
From: Vasiliy Kulikov <segoon@...nwall.com>
To: Américo Wang <xiyou.wangcong@...il.com>
Cc: kernel-hardening@...ts.openwall.com,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, Alexey Dobriyan <adobriyan@...il.com>,
	Al Viro <viro@...iv.linux.org.uk>, "H. Peter Anvin" <hpa@...or.com>,
	Greg KH <greg@...ah.com>, Theodore Tso <tytso@....edu>,
	Alan Cox <alan@...rguk.ukuu.org.uk>,
	Linus Torvalds <torvalds@...ux-foundation.org>
Subject: Re: [RFC 1/3] procfs: parse mount options

Hi Américo,

On Tue, Nov 15, 2011 at 19:48 +0800, Américo Wang wrote:
> On Tue, Nov 15, 2011 at 7:21 PM, Vasiliy Kulikov <segoon@...nwall.com> wrote:
> > +
> > +static int proc_parse_options(char *options, struct pid_namespace *pid)
> > +{
> > +       char *p;
> > +       substring_t args[MAX_OPT_ARGS];
> > +       int option;
> 
> 
> 'option' is unused?

Right.

> > +               switch (token) {
> > +               default:
> 
> 
> This switch block reads odd...

It will be used in 2/3 patch.

> > +                       pr_err("proc: unrecognized mount option \"%s\" "
> > +                              "or missing value", p);
> 
> "\n" is needed.

Correct.  Thank you!

> > +                       return 0;
> > +               }
> > +       }
> > +
> > +       return 1;
> > +}

-- 
Vasiliy Kulikov
http://www.openwall.com - bringing security into open computing environments

Powered by blists - more mailing lists

Your e-mail address:

Powered by Openwall GNU/*/Linux - Powered by OpenVZ