Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Sun, 23 Dec 2012 13:34:42 +0100
From: magnum <john.magnum@...hmail.com>
To: john-users@...ts.openwall.com
Subject: Re: gpg2john -> false positive -> how to exclude?

On 23 Dec, 2012, at 12:21 , Dhiru Kholia <dhiru.kholia@...il.com> wrote:
> Here is a better patch (to avoid stream of wrong passwords).
> 
> diff --git a/src/gpg_fmt_plug.c b/src/gpg_fmt_plug.c
> index 644126b..3b53852 100644
> --- a/src/gpg_fmt_plug.c
> +++ b/src/gpg_fmt_plug.c
> @@ -787,7 +787,11 @@ static int cmp_one(void *binary, int index)
> 
> static int cmp_exact(char *source, int index)
> {
> -       return cracked[index];
> +       if(cracked[index]) {
> +               cracked[index] = 0;
> +               return 1;
> +       }
> +       return 0;
> }

"any_cracked" should be reset somewhere as well, for running with just one "salt". It will work fine anyway but cmp_all() will permanently return true after the first guess, so cmp_one() will always be called. Not that it will affect speed much.

The OpenCL format needs none of these fixes, just FMT_NOT_EXACT added to the flags.

magnum

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.