john-users - Plumbing changes (was: Re: Following all the patch activity, not uploading to the wiki, which patches play well together, revising the wiki page to be better)

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Sat, 07 May 2011 00:20:09 +0200
From: magnum <rawsmooth@...dband.net>
To: john-users@...ts.openwall.com
Subject: Plumbing changes (was: Re: Following all the patch activity, not
 uploading to the wiki, which patches play well together, revising the wiki
 page to be better)

On 2011-05-06 23:29, jfoug wrote:
>> From: magnum [mailto:rawsmooth@...dband.net]
>> It will likely get even worse when Jim posts his "plumbing changes"
>> patches for 1.7.7 and we start to rebase to that. Then eventually it
>> will get much better.
>
> I am hoping that Solar places this into jumbo.

I sure do too, they are very good changes that make everything cleaner 
and more modular. There are improvements to make to the NET*LM parsing 
that I won't even try until after your patch.

Speaking of that, I did improve the current loader.c for NET*LM in my 
UTF-8 patch. Should I post versions of those formats rebased onto the 
plumbing-changes patch?

Maybe I should also implement that "auto-generated format list" for 
options.c that I have been thinking about... this would mitigate a lot 
of patch collisions. Together with your changes, most new formats would 
only add one line in Makefile and two in john.c

magnum