john-users - "--config" option

[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Date: Wed, 28 Jul 2010 11:26:05 -0500
From: jmk <jmk@...fus.net>
To: john-users@...ts.openwall.com
Subject: "--config" option

Hi,

I was recently emailed that my netntlm.pl script isn't working with
recent John Jumbo patches. I traced the problem to my "--config" option
hack (it always returns an "Invalid options combination or duplicate
option" error). I apologize for any inconvenience this may have caused.
We've always been running the script with an older version of John,
which, for some reason, didn't exhibit the problem.

I've attached a patch which I think resolves the problem. Unfortunately,
I'm not confident that I understand which flags should be set on an
option of this type. I was hoping someone could take a quick look it. If
it seems sane, I'll uploaded it to the wiki.

Thanks,
Joe



diff -rub john-1.7.6-jumbo-6/src/options.c john-1.7.6-jumbo-6-jmk/src/options.c
--- john-1.7.6-jumbo-6/src/options.c	2010-07-28 11:03:54.157485013 -0500
+++ john-1.7.6-jumbo-6-jmk/src/options.c	2010-07-28 11:06:52.090957931 -0500
@@ -96,8 +96,8 @@
 		"%u", &options.loader.max_fix_state_delay},
 	{"field-separator-char", FLG_NONE, FLG_NONE, 0, OPT_REQ_PARAM,
 		OPT_FMT_STR_ALLOC, &field_sep_char_string},
-	{"config", FLG_CONFIG_OPT, FLG_CONFIG_CLI, FLG_CONFIG_CLI,
-		OPT_REQ_PARAM, OPT_FMT_STR_ALLOC, &options.config},
+	{"config", FLG_CONFIG_CLI, FLG_NONE, 0, OPT_REQ_PARAM,
+		OPT_FMT_STR_ALLOC, &options.config},
 	{NULL}
 };
 
diff -rub john-1.7.6-jumbo-6/src/options.h john-1.7.6-jumbo-6-jmk/src/options.h
--- john-1.7.6-jumbo-6/src/options.h	2010-07-28 11:03:54.157485013 -0500
+++ john-1.7.6-jumbo-6-jmk/src/options.h	2010-07-28 11:05:48.719710873 -0500
@@ -91,16 +91,8 @@
 #define FLG_MKV_CHK			0x40000000
 #define FLG_MKV_SET			(FLG_MKV_CHK | FLG_CRACKING_SET)
 
-/*
- * Command-line config file.
- *
- * FLG_CONFIG_DEFAULT is probably not needed.  The author if this patch didn't
- * recall why it was added:
- * http://www.openwall.com/lists/john-users/2010/05/04/1
- */
-#define FLG_CONFIG_DEFAULT 0x10000000
-#define FLG_CONFIG_CLI     0x80000000
-#define FLG_CONFIG_OPT     (FLG_CONFIG_DEFAULT | FLG_CONFIG_CLI)
+/* Command-line config file */
+#define FLG_CONFIG_CLI     0x10000000
 
 /*
  * Structure with option flags and all the parameters.