john-users - Re: 1.7.6-jumbo-2

Openwall GNU/*/Linux 3.0 - a small security-enhanced Linux distro for servers

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 17 Jun 2010 02:18:36 +0400
From: Solar Designer <solar@...nwall.com>
To: john-users@...ts.openwall.com
Subject: Re: 1.7.6-jumbo-2

Erik, W.A., all -

I've just released 1.7.6-jumbo-3, which should build cleanly on Mac OS X
(it does on my 10.5 with somewhat-dated Xcode).

I haven't looked into updating the MPI patch yet.

On Tue, Jun 15, 2010 at 08:58:32AM -0400, Erik Winkler wrote:
> The compile error on Mac OSX is due to the fact that u_char is defined in sys/types.h.  Adding the following line to KRB4_fmt.c will solve the compile error.
> 
> #include <sys/types.h>

Thanks.  I've solved this differently, though - by using "unsigned char".

> Also, NETLMv2_fmt.c and NETNTLMv2_fmt.c need to have the following changed to static to eliminate the "duplicate symbol" ld errors:
> 
> uchar saved_plain[PLAINTEXT_LENGTH + 1];
> uchar challenge[SALT_SIZE + 1];
> uchar output[BINARY_SIZE + 1];
> 
> must be changed to:
> 
> static uchar saved_plain[PLAINTEXT_LENGTH + 1];
> static uchar challenge[SALT_SIZE + 1];
> static uchar output[BINARY_SIZE + 1];

Right.  I've included this change.

Thank you!

Alexander