john-users - Re: bench.c fix for extreme c/s figures

Openwall GNU/*/Linux 3.0 - a small security-enhanced Linux distro for servers

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Sat, 27 Mar 2010 15:27:26 +0300
From: Solar Designer <solar@...nwall.com>
To: john-users@...ts.openwall.com
Subject: Re: bench.c fix for extreme c/s figures

On Sat, Mar 27, 2010 at 01:12:26PM +0100, Magnum, P.I. wrote:
> The Jumbo patches use long long's anyway so I now fixed bench.c without 
> the half-assed try to keep using the int64. I just uploaded fullmpi-6 to 
> the wiki. Works fine on Linux 32 and 64, I hope it works for W.A too.

We'll see it it works for W.A. or not.  Meanwhile, I notice that it
will likely fail on 32-bit builds, because neither "count" nor "clk_tck"
is cast to a 64-bit type before you multiply them.  You will likely want
to add a cast to (unsigned long long) in two places.  Also, I suggest
that you use "unsigned long long", not just "long long".

Thanks,

Alexander