john-users - Re: [patch] fix format errors

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 14 Sep 2009 06:28:45 +0400
From: Solar Designer <solar@...nwall.com>
To: john-users@...ts.openwall.com
Subject: Re: [patch] fix format errors

On Sun, Sep 13, 2009 at 04:30:34PM +0200, Guillaume Rousse wrote:
> The following patch fix build error with -Wformat -Werror=format-security.

Thanks.  I've applied the change with the following commit message:

Fixed a pexit() call in recovery.c: rec_format_error() to build with -Wformat
-Werror=format-security, although there was no real issue with the current code
(the corresponding argument to rec_format_error() was a string literal on all
calls to that function).  This was independently discovered and reported by
Dmitry V. Levin and Guillaume Rousse.

Then I made some corrections/enhancements to recovery.c's error
handling, which may actually affect runtime behavior in some subtle
cases.  All of this will appear in 1.7.3.4+.

Alexander