Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Sat, 23 Jan 2016 17:42:00 +0300
From: Solar Designer <solar@...nwall.com>
To: john-dev@...ts.openwall.com
Subject: Re: loader and cracker (prefetch) optimizations from September 2015

Hi magnum,

On Fri, Jan 22, 2016 at 06:24:08PM +0100, magnum wrote:
> I think I got it right: Attached is the net changes to Jumbo.

These look good to me, except that in cracker.c there's this redundant
piece left:

#if CRK_PREFETCH && defined(__SSE2__)
#include <emmintrin.h>
#endif

it becomes redundant with the addition of:

#if CRK_PREFETCH && defined(__SSE__)
#include <xmmintrin.h>
#endif

higher in the same file.  Please remove the __SSE2__ / emmintrin.h piece.

> I did not "reduce CRACKED_HASH_LOG from jumbo's 25 to 21"... should we 
> do so in Jumbo?

I think not.  Let's keep things as they are.

Thanks!

Alexander

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.