Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Date: Mon, 18 Jan 2016 22:20:45 +0100
From: Frank Dittrich <frank.dittrich@...lbox.org>
To: john-dev@...ts.openwall.com
Subject: Use __ARM_NEON instead of __ARM_NEON__

Solar,

apparently, __ARM_NEON__ is legacy, since it is not defined in the 
ARM(R) C Language Extensions Release 1.1:
 
http://infocenter.arm.com/help/topic/com.arm.doc.ihi0053b/IHI0053B_arm_c_language_extensions_2013.pdf.
Instead, __ARM_NEON should be used, see chapter 4.4 (ACLE headers).

This seems to be confirmed by 
https://gcc.gnu.org/ml/gcc-patches/2015-01/msg02717.html).
So, we should make sure to replace all occurrences of __ARM_NEON__ with 
__ARM_NEON.

For Jumbo, I created an issue on github:
https://github.com/magnumripper/JohnTheRipper/issues/1998

These are the __ARM_NEON__ references in master:

(master)src $ git grep -n ARM_NEON
DES_bs_b.c:25:#if defined(__ARM_NEON__) && DES_BS_DEPTH == 64
DES_bs_b.c:56:#elif defined(__ARM_NEON__) && ARCH_BITS == 32 && 
DES_BS_DEPTH == 96
DES_bs_b.c:90:#elif defined(__ARM_NEON__) && DES_BS_DEPTH == 128 && 
defined(DES_BS_2X64)
DES_bs_b.c:125:#elif defined(__ARM_NEON__) && DES_BS_DEPTH == 128
DES_bs_b.c:156:#elif defined(__ARM_NEON__) && \
DES_bs_b.c:192:#elif defined(__ARM_NEON__) && DES_BS_DEPTH == 256
arm32le.h:39:#ifdef __ARM_NEON__

Frank

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.