Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date: Sun, 1 Nov 2015 11:48:51 +0100
From: Solar Designer <solar@...nwall.com>
To: john-dev@...ts.openwall.com
Subject: Re: dereferencing type-punned pointer will break strict-aliasing rules in DES_bs_b.c (linux-arm32le-neon)

Hi Frank,

These are known issues, discussed in here before.

On Sun, Nov 01, 2015 at 01:32:47AM +0100, Frank Dittrich wrote:
> After getting tons of warnings when building bleeding-jumbo on Raspberry
> Pi 2, verified that the same warnings occur with master.
> 
> $ make -s linux-arm32le-neon
> DES_std.c: In function ???DES_std_set_key???:
> DES_std.c:635:17: warning: array subscript is above array bounds
> [-Warray-bounds]
>    while (DES_key[i++]) k += 2;
>                  ^

This is a gcc bug:

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=59124

> DES_bs_b.c: In function ???DES_bs_finalize_keys???:
> DES_bs_b.c:1241:4: warning: dereferencing type-punned pointer will break
> strict-aliasing rules [-Wstrict-aliasing]

These are JtR bugs that I haven't gotten around to dealing with yet.
As you say, JtR works fine despite of them so far, and due to our
runtime self-test a user would know whenever this breaks.  In a
discussion thread with Lei, we determined that these typecasts appear to
be fine on x86, but not necessarily so on other archs for which we use
SIMD intrinsics as well.

> This is the github issue:
> https://github.com/magnumripper/JohnTheRipper/issues/1871

Please update it with the above detail.

Thanks,

Alexander

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.