Openwall GNU/*/Linux - a small security-enhanced Linux distro for servers
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Thu, 17 Sep 2015 12:53:23 +0200
From: Frank Dittrich <frank.dittrich@...lbox.org>
To: john-dev@...ts.openwall.com
Subject: Re: multi-threaded hash table initialization

On 09/17/2015 12:37 AM, magnum wrote:
> FYI your patch doesn't apply cleanly to current bleeding (despite, I'm
> pretty sure, there should be no clash at all with recent commits). This
> happened with one of your patches yesterday also and it's probably very
> trival this time too but it'll take me some head scratching and thus
> some delay. It's not really a problem, just wanted to let you know.

It also causes a warning for non-OMP builds:

loader.c: In function ‘ldr_fix_database’:
loader.c:1508:2: warning: ‘hash_alloc’ may be used uninitialized in this
function [-Wmaybe-uninitialized]
  memset(salt->hash, 0, hash_alloc);
  ^
loader.c:1409:23: note: ‘hash_alloc’ was declared here
  size_t bitmap_alloc, hash_alloc;
                       ^

... and tons of jtrts.pl failures

form=dynamic_0                    guesses:    0 -show=   0 unk unk :
Expected count(s) (1500)(-show1502)  [!!!FAILED2!!! exited, return code 1]
.pot CHK:dynamic_0                guesses:    0 -show=   0 unk unk :
Expected count(s) (1500)  [!!!FAILED4!!!]  (0 val-pwd  1 inval-pwd)

form=dynamic_0                    guesses:    0 -show=   0 unk unk :
Expected count(s) (1500)(920)  [!!!FAILED2!!! exited, return code 1]
.pot CHK:dynamic_0                guesses:    0 -show=   0 unk unk :
Expected count(s) (1500)  [!!!FAILED4!!!]  (0 val-pwd  1 inval-pwd)

form=dynamic_0                    guesses:    0 -show=   0 unk unk :
Expected count(s) (1500)  [!!!FAILED2!!! exited, return code 1]
.pot CHK:dynamic_0                guesses:    0 -show=   0 unk unk :
Expected count(s) (1500)  [!!!FAILED4!!!]  (0 val-pwd  1 inval-pwd)

form=dynamic_0-raw                guesses:    0 -show=   0 unk unk :
Expected count(s) (1500)  [!!!FAILED2!!! exited, return code 1]
.pot CHK:dynamic_0-raw            guesses:    0 -show=   0 unk unk :
Expected count(s) (1500)  [!!!FAILED4!!!]  (0 val-pwd  1 inval-pwd)

form=dynamic_1                    guesses:    0 -show=   0 unk unk :
Expected count(s) (1500)  [!!!FAILED2!!! exited, return code 1]
.pot CHK:dynamic_1                guesses:    0 -show=   0 unk unk :
Expected count(s) (1500)  [!!!FAILED4!!!]  (0 val-pwd  1 inval-pwd)

form=dynamic_1                    guesses:    0 -show=   0 unk unk :
Expected count(s) (1500)(923)  [!!!FAILED2!!! exited, return code 1]
.pot CHK:dynamic_1                guesses:    0 -show=   0 unk unk :
Expected count(s) (1500)  [!!!FAILED4!!!]  (0 val-pwd  1 inval-pwd)

form=dynamic_2                    guesses:    0 -show=   0 unk unk :
Expected count(s) (1500)  [!!!FAILED2!!! exited, return code 1]
.pot CHK:dynamic_2                guesses:    0 -show=   0 unk unk :
Expected count(s) (1500)  [!!!FAILED4!!!]  (0 val-pwd  1 inval-pwd)

form=dynamic_2                    guesses:    0 -show=   0 unk unk :
Expected count(s) (1500)(920)  [!!!FAILED2!!! exited, return code 1]
.pot CHK:dynamic_2                guesses:    0 -show=   0 unk unk :
Expected count(s) (1500)  [!!!FAILED4!!!]  (0 val-pwd  1 inval-pwd)

form=dynamic_2-raw                guesses:    0 -show=   0 unk unk :
Expected count(s) (1500)  [!!!FAILED2!!! exited, return code 1]
.pot CHK:dynamic_2-raw            guesses:    0 -show=   0 unk unk :
Expected count(s) (1500)  [!!!FAILED4!!!]  (0 val-pwd  1 inval-pwd)


Powered by blists - more mailing lists

Your e-mail address:

Powered by Openwall GNU/*/Linux - Powered by OpenVZ