Openwall GNU/*/Linux - a small security-enhanced Linux distro for servers
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Wed, 16 Sep 2015 03:49:44 +0200
From: magnum <john.magnum@...hmail.com>
To: john-dev@...ts.openwall.com
Subject: Re: ldr_split_line() performance regression

On 2015-09-16 02:16, Solar Designer wrote:
> There's some ridiculous stuff in ldr_split_line() in jumbo now, such as
> repeated uses of cfg_get_bool().  This (or/and something else) made JtR
> unusably slow for me when not forcing a specific format.  Just try
> running it on pw-fake-unix from:
>
> http://openwall.info/wiki/john/sample-hashes#Sample-password-hash-files
>
> without requesting any format.  It takes tens of seconds to load that
> tiny file now, which was previously loaded instantly.
>
> Please keep any non-trivial processing out of ldr_split_line(), or at
> least limit it to only be done once (e.g., by using static variables).

Ouch! I use to be careful with these things... but the ones for 
"Disabled formats" were really bad. Fixed now, and loading of that 
sample literally went from 2 minutes to 900 ms on my laptop...

I already intended to audit all use of cfg_get* some day, because I 
suspect there may be more problems.

magnum

Powered by blists - more mailing lists

Your e-mail address:

Powered by Openwall GNU/*/Linux - Powered by OpenVZ