Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Sun, 6 Sep 2015 14:07:25 -0500
From: JimF <jfoug@....net>
To: john-dev@...ts.openwall.com
Subject: Re: auditing our use of FMT_* flags

On 9/6/2015 2:01 PM, Solar Designer wrote:
> On Sun, Sep 06, 2015 at 01:51:44PM -0500, JimF wrote:
>> Now, in hind sight, is this flag something required prior to init()
> Actually, yes, I think so.
>
>> I do not think split is available before init()
> It is, per the formats interface definition:
>
>   * prepare(), valid(), and split() are the only methods that are allowed to be
>   * called before a call to init().
>
> Alexander

Then we should set this flag, even though dyna's linker/init will reset 
it internally, and the original bug catch was 100% valid.  I am just 
wondering why we could not replicate any form of problem, other than the 
bug finder telling us of this issue?  I know Frank hammered away with 20 
or 30 of them last fall (I think last fall). They were all trivial 
fixes.  I just wonder why these formats have not demonstrated negative 
side effects up to this point.

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.