Openwall GNU/*/Linux - a small security-enhanced Linux distro for servers
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Mon, 24 Aug 2015 09:37:36 +0800
From: Kai Zhao <loverszhao@...il.com>
To: john-dev@...ts.openwall.com
Subject: Re: testing every index (Re: more robustness)

Hi Alexander,

On Sun, Aug 23, 2015 at 9:28 PM, Kai Zhao <loverszhao@...il.com> wrote:
> Hi Alexander,
>
> On Sun, Aug 23, 2015 at 2:22 AM, Solar Designer <solar@...nwall.com> wrote:
>>
>> If you re-order the test vectors, e.g. swap 5 and 7, will this hide this
>> unusual property from your current test?  If so, maybe do that (even
>> though it's very nice your test let us know of this property now).
>
> Yes. After swap the 5th and 7th, the --test-full could not detect this problem.
> Should we commit this change ?
>
> diff --git a/src/AFS_fmt.c b/src/AFS_fmt.c
> index 01bd3ad..3f2507e 100644
> --- a/src/AFS_fmt.c
> +++ b/src/AFS_fmt.c
> @@ -33,9 +33,9 @@ static struct fmt_tests tests[] = {
>         {"$K4$d9e985b36268f168,01234567", "U*U***U"},
>         {"$K4$b9615786dfb53297,longcellname", "longpassword"},
>         {"$K4$a8dc8aeaa2c48a97,", ""},
> -       {"$K4$dfda85c7619183a2,XXXXXXXX", "XXXXXXXX"},
>         {"$K4$e3e59de6f1d5eaf4,cell", "password355"},
>         {"$K4$b02cc24aefbc865b,", "thisisaverylongpassword"},
> +       {"$K4$dfda85c7619183a2,XXXXXXXX", "XXXXXXXX"},
>         {NULL}
>  };

Sorry. I found a bug with --test-full, and I have fixed it. Now, change
the order of test vectors of AFS could not help. It will fail because ""
and "XXXXXXXX" generate the same xor.

When test the test vector {"$K4$a8dc8aeaa2c48a97,", ""},
the cell is:

00 00 00 00 00 00 00 00 6E 61 6D 65 00 00 00 00 00 00 00 00 00 00 00
00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
00 00

the xor is:

00 00 00 00 00 00 00 00

so for password "" and "XXXXXXXX" the xor which is sent to
DES_std_set_key() are the same:

58 58 58 58 58 58 58 58

So both "" and "XXXXXXXX" are the correct passwords.
Should we add FMT_NOT_EXACT for AFS ?


Thanks,

Kai

Powered by blists - more mailing lists

Your e-mail address:

Powered by Openwall GNU/*/Linux - Powered by OpenVZ