Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Fri, 21 Aug 2015 11:23:50 -0500
From: JimF <jfoug@....net>
To: john-dev@...ts.openwall.com
Subject: Re: The cmp_all() of cq

On Fri, 21 Aug 2015 11:14:57 -0500, Kai Zhao <loverszhao@...il.com> wrote:

> The cmp_all() of cq seems never return 0. Is this right ?
>
> static int cmp_all(void *binary, int count)
> {
>         int i = 0;
>
> #if defined(_OPENMP) || MAX_KEYS_PER_CRYPT > 1
>         for (i = 0; i < count; ++i)
> #endif
>         {
>                 if ((*(unsigned int*)binary) == *(unsigned  
> int*)crypt_key[i])
>                         return 1;
>         }
>
>         return count;
> }

That looks like a bug to me.  self-test does not catch this?!

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.