Openwall GNU/*/Linux - a small security-enhanced Linux distro for servers
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Wed, 19 Aug 2015 03:51:09 +0300
From: Solar Designer <solar@...nwall.com>
To: john-dev@...ts.openwall.com
Subject: Re: FMT_OMP_BAD

On Wed, Aug 19, 2015 at 08:37:27AM +0800, Kai Zhao wrote:
> On Wed, Aug 19, 2015 at 8:34 AM, Solar Designer <solar@...nwall.com> wrote:
> > Also, I noticed that all of them lack proper test vectors - some have
> > just one correct password, some even test empty string only.  Please get
> > this corrected (you may create a GitHub issue to track this).
> 
> Is the previous issue ok ?
> 
> https://github.com/magnumripper/JohnTheRipper/issues/1637

It's OK to add to that existing issue, yes.

> And I am trying to add more test vectors for those formats whose
> the number of test vectors is small than 2.

You should consider the effective number of test vectors, not just the
number of test vectors listed.  For example, this:

static struct fmt_tests haval_128_4_tests[] = {
	{"EE6BBF4D6A46A679B3A856C88538BB98", ""},
	{"$haval$ee6bbf4d6a46a679b3a856c88538bb98", ""},
	{NULL}
};

is effectively just one test vector, not two.  It's just testing two
different encodings.  Similarly, haval_256_3_tests[] has 3 encodings of
effectively one test vector.  There are probably more cases like this.

Alexander

Powered by blists - more mailing lists

Your e-mail address:

Powered by Openwall GNU/*/Linux - Powered by OpenVZ