Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list] 
Date: Mon, 17 Aug 2015 23:46:04 +0800
From: Kai Zhao <loverszhao@...il.com>
To: john-dev@...ts.openwall.com
Subject: Re: FMT_OMP_BAD

Hi Alexander,

I find some formats set FMT_OMP flag without judging the value of
_OPENMP. Such as mysql_fmt_plug.c:

struct fmt_main fmt_MYSQL_fast =
{
        {
                [...]
                MAX_KEYS_PER_CRYPT,
                FMT_CASE | FMT_8_BIT | FMT_SPLIT_UNIFIES_CASE | FMT_OMP,
                { NULL },
                tests
        },
        [...]
}

I think it should be:

struct fmt_main fmt_MYSQL_fast =
{
        {
                [...]
                MAX_KEYS_PER_CRYPT,
#ifdef _OPENMP
                FMT_OMP |
#endif
                FMT_CASE | FMT_8_BIT | FMT_SPLIT_UNIFIES_CASE,
                { NULL },
                tests
        },
        [...]
}

I think we should add the macro around the FMT_OMP flag if it in
the struct fmt_main in all the *fmt_plug.c files. Should we ?

struct fmt_main ... {
{
        [...]
#ifdef _OPENMP
                FMT_OMP |
#endif
        [...]
};


Thanks,

Kai

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.