Openwall GNU/*/Linux - a small security-enhanced Linux distro for servers
[<prev] [next>] [day] [month] [year] [list]
Date: Tue, 21 Jul 2015 12:39:45 -0400
From:  <jfoug@....net>
To: john-dev@...ts.openwall.com
Subject: Re: more robustness

---- Kai Zhao <loverszhao@...il.com> wrote: 
> Finally, there are no formats have obvious problems with
> FMT_SPLIT_UNIFIES_CASE flag. But there are 3 formats: MediaWiki,
> PHPS, PHPS2 which do not contain the flag and their split do not
> change case. But the 3 formats finally has the flag:
> FMT_SPLIT_UNIFIES_CASE.
> 
> I think it is because they are dynamic formats, and their flags are
> are changed at dynamic_fmt.c::7449
> pFmt->params.flags |= FMT_SPLIT_UNIFIES_CASE;
> 
> I do't know whether the 3 formats should contain the split flag.

It would not matter.  For thin formats, the format flags get setup during the 'linkage' to dynamic. If you wanted to add Flags like these to the format structure in the format file to pacify some issue-finder script, then go right ahead. But it does not matter what flags you add to the format structure in the file. The flags that actually get 'used' will have nothing to do with what was static set at compile time.  The reason this late setup is done, is because dynamic will know if unifies case should be used or not. In dynamic it is always used, unless the input hash uses base-64

Powered by blists - more mailing lists

Your e-mail address:

Powered by Openwall GNU/*/Linux - Powered by OpenVZ