Openwall GNU/*/Linux - a small security-enhanced Linux distro for servers
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Mon, 1 Jun 2015 09:21:44 +0300
From: Shinnok <admin@...nnok.com>
To: john-dev@...ts.openwall.com
Subject: Re: [john-core] Getting John's stdout unbuffered for Johnny


> On May 31, 2015, at 4:01 PM, Solar Designer <solar@...nwall.com> wrote:
> 
> On Sat, May 30, 2015 at 08:44:46AM +0300, Solar Designer wrote:
>> Shinnok, just let me know what the Johnny team decides on this.  If you
>> ask me to, I think I'll add a call to:
>> 
>> setvbuf(stdout, NULL, _IOLBF, 0);
>> 
>> to john.c: john_init().
>> 
>> It is important to keep stdout with its default buffering when john is
>> invoked via one of the un* symlinks, since they're commonly used with
>> stdout pointing at a disk file.
> 
> I've just committed the change documented as:
> 
> Set stdout to line buffered (rather than potentially fully buffered), except
> for "--stdout", "--show", and auxiliary programs such as "unshadow".
> 
> http://cvsweb.openwall.com/cgi/cvsweb.cgi/Owl/packages/john/john/src/john.c.diff?r1=1.71;r2=1.73
> 

Mathieu, can you test this change and see how well it plays with Johnny?

Shinnok

Powered by blists - more mailing lists

Your e-mail address:

Powered by Openwall GNU/*/Linux - Powered by OpenVZ