Openwall GNU/*/Linux - a small security-enhanced Linux distro for servers
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date: Mon, 1 Jun 2015 09:07:17 +0300
From: Shinnok <admin@...nnok.com>
To: john-dev@...ts.openwall.com
Subject: Re: problem with signal handling in core john (was: [core john] [Johnny] Windows event loop)


> On May 31, 2015, at 10:16 AM, Solar Designer <solar@...nwall.com> wrote:
> 
> Hi Shinnok,
> 
> On Mon, May 25, 2015 at 05:40:22PM +0300, Shinnok wrote:
>> Alexander, will you integrate the patch in question in this case?
> 
> OK, I made two commits:
> 
> http://cvsweb.openwall.com/cgi/cvsweb.cgi/Owl/packages/john/john/src/signals.c
> 
> http://cvsweb.openwall.com/cgi/cvsweb.cgi/Owl/packages/john/john/src/signals.c.diff?r1=1.24;r2=1.26
> 
> While at it, I also changed all __CYGWIN32__ to __CYGWIN__ elsewhere in
> the tree and removed bits that were specific to ancient Cygwin versions
> (which would define __CYGWIN32__ but not __CYGWIN__).

Thanks for integrating. Btw, your commit doesn't extend beyond signals.c; relative to "elsewhere in the tree".

> 
> I didn't add #include <wincon.h>, which was in your patch.  This
> appeared wrong to me, because it was not needed so far and we're not
> starting to use any new symbol with this patch.  Additionally, the MSDN
> page on SetConsoleCtrlHandler() says:
> 
> "Header	Wincon.h (include Windows.h)"
> 
> which might mean that we should be including windows.h only, just like
> we do now.
> 
> Is this OK?

Mathieu replied with confirmation that it does work without wincon.h.

Thanks again,
Shinnok

Powered by blists - more mailing lists

Your e-mail address:

Powered by Openwall GNU/*/Linux - Powered by OpenVZ