Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Mon, 25 May 2015 17:40:22 +0300
From: Shinnok <admin@...nnok.com>
To: john-dev@...ts.openwall.com
Subject: Re: problem with signal handling in core john (was: [core john] [Johnny] Windows event loop)


> On May 24, 2015, at 5:19 PM, Aleksey Cherepanov <lyosha@...nwall.com> wrote:
> 
> Mathieu,
> 
> On Sun, May 24, 2015 at 10:04:44AM -0400, Mathieu Laprise wrote:
>> On Sun, May 24, 2015 at 9:51 AM, Aleksey Cherepanov <lyosha@...nwall.com>
>> wrote:
>> 
>>> Did you apply Shinnok's patch that replaces __CYGWIN32__ and then
>>> removed SetConsoleCtrlHandler(NULL, FALSE); ? Or did you try without
>>> the patch at all?
>>> 
>> 
>> I tried without the patch at all. Since with CTRL+Break, I managed to
>> trigger the code and also printf() some cmd at those lines, I know that the
>> __CYGWIN32__ macro was defined on my system, even though it's better to
>> replace it like Shinnok did for the future. Should I retest it with
>> __CYGWIN__ ?
> 
> I think it is not needed to retest it. It would be a waste to spend
> more of your time on that. Please proceed to other tasks. Thanks!
> 

Mathieu, thanks for trying this.

Alexander, will you integrate the patch in question in this case?

Shinnok

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.