Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date: Wed, 6 May 2015 23:19:23 +0300
From: Solar Designer <solar@...nwall.com>
To: john-dev@...ts.openwall.com
Subject: Re: John core: --format=crypt rejecting descrypt hashes when it first found some bfegg hashes

On Wed, May 06, 2015 at 10:04:36PM +0200, magnum wrote:
> On 2015-05-06 21:18, magnum wrote:
> >c3_fmt.c: In function 'valid':
> >c3_fmt.c:100:19: warning: 'count_base64_2' may be used uninitialized in
> >this function [-Wmaybe-uninitialized]
> >   if (length >= 13 &&
> >                    ^
> >
> >I had no time to review it yet, might be a false positive. This was gcc
> >4.9.2.
> 
> Oh, it really is an uninitialized variable. Any version of gcc should 
> complain about it. I'm guessing last-minute-change that went bad?

Sort of.  I've just checked, my gcc 4.6.3 did complain.  I don't know
how I did not notice.

Fixed.  Thanks!

Alexander

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.