Openwall GNU/*/Linux - a small security-enhanced Linux distro for servers
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Tue, 31 Mar 2015 21:46:50 +0200
From: magnum <john.magnum@...hmail.com>
To: john-dev@...ts.openwall.com
Subject: Re: [GSoC] John the Ripper support for PHC finalists

On 2015-03-31 12:46, Jeremi M Gosney wrote:
>> -----Original Message----- From: magnum Sent: Monday, March 30,
>> 2015 02:51
>> This patch fixes the auto-tune problems. BTW with my other
>> suggestions it also runs fine on the GTX Titan, at about same ~10K
>> c/s speed as on HD7970. And now it also runs on my Macbook GPU
>> (1290 c/s).
> 
> 
> I had to change "char build_opts[64]" to "char build_opts[64] = {0};"
> in init() in order to get this to run, otherwise it would fail with
> the following error:
> 
> OpenCL error (CL_INVALID_DEVICE) in file (common-opencl.c) at line
> (969) - (Error while getting build info I)

This was already discussed in
http://www.openwall.com/lists/john-dev/2015/03/30/8 so did not include
it in the autotune patch:

On 2015-03-30 02:11, magnum wrote:
> What you should do is this right before opencl_init():
> 
> +  sprintf(build_opts, "-DBINARY_SIZE=%d -DSALT_SIZE=%d -DMEM_SIZE=%d",
> +          BINARY_SIZE, SALT_SIZE, MEM_SIZE);
> 
> And a corresponding change to the kernel:
> 
> -#define BINARY_SIZE     257
> -#define SALT_SIZE       32
> -#define MEM_SIZE        131072
> +// BINARY_SIZE, SALT_SIZE and MEM_SIZE is passed with -D during build

Just clearing it is fine, the patch fragments above are just a bit more
future proof.

magnum

Powered by blists - more mailing lists

Your e-mail address:

Powered by Openwall GNU/*/Linux - Powered by OpenVZ