Openwall GNU/*/Linux - a small security-enhanced Linux distro for servers
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Fri, 20 Mar 2015 20:51:19 +0800
From: Lei Zhang <zhanglei.april@...il.com>
To: john-dev@...ts.openwall.com
Subject: Re: [GSoC] building JtR for MIC


> Or is this possibly a side-effect of -D_GNU_SOURCE?  Do these warnings
> appear without -D_GNU_SOURCE?

Without _GNU_SOURCE defined, some other compile errors will pop out, like this one:
--------------------------------------------------------------------------------
icc -mmic -DAC_BUILT -no-opt-prefetch -c -g -O2 -DARCH_LITTLE_ENDIAN=1     -fopenmp  -pthread  -I/home/zhanglei/mic/include  rar2john.c -o rar2john.o
rar2john.c(198): error #140: too many arguments in function call
 				if( (pos = memmem(buf, count, "\x52\x61\x72\x21\x1a\x07\x00", 7))) {
 				                              ^

rar2john.c(749): error #140: too many arguments in function call
 				if( (pos = (char*)memmem(buf, count, "\x52\x61\x72\x21\x1a\x07\x01\x00", 8))) {
 				                                     ^

compilation aborted for rar2john.c (code 2)
---------------------------------------------------------------------------------
Actually this reveals another bug in icc, as I reported before. But I haven't investigated why defining _GNU_SOURCE eliminates this error.


> We have our own bzero() as a macro in jumbo.h.  We should get rid of it,
> and of all uses of bzero() in jumbo if there are any (I think not).

So I could remove all bzero-related code? That should be no problem.


> strcasecmp() in jumbo.c is obviously buggy (won't compile, so probably
> never tested - we should fix and test it), and besides it shouldn't be
> enabled for this build.  Please investigate what caused it to be enabled.

There's a bug in jumbo.h, line 209:
----------------------------
#if !AC_BUILT
----------------------------
Actually AC_BUILT is defined in command line by -DAC_BUILT, and it won't pass this test. We should use #ifndef instead.


Lei

Powered by blists - more mailing lists

Your e-mail address:

Powered by Openwall GNU/*/Linux - Powered by OpenVZ