Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Fri, 20 Mar 2015 05:33:21 +0300
From: Solar Designer <solar@...nwall.com>
To: john-dev@...ts.openwall.com
Subject: Re: [GSoC] building JtR for MIC

On Fri, Mar 20, 2015 at 05:13:20AM +0300, Solar Designer wrote:
> On Fri, Mar 20, 2015 at 12:29:16AM +0100, magnum wrote:
> > On 2015-03-18 11:38, Solar Designer wrote:
> > > I notice that in jumbo my original mic.h is modified to use autoconf'ed
> > > ARCH_* settings:
> > > 
> > > #if AC_BUILT
> > > #include "autoconfig.h"
> > > #else
> > > #define ARCH_WORD                       long
> > > #define ARCH_SIZE                       8
> > > #define ARCH_BITS                       64
> > > #define ARCH_BITS_LOG                   6
> > > #define ARCH_BITS_STR                   "64"
> > > #define ARCH_LITTLE_ENDIAN              1
> > > #define ARCH_INT_GT_32                  0
> > > #endif
> > > 
> > > This might be wrong since we're cross-compiling.  I doubt it's causing
> > > trouble now, though, since the host system is almost certainly x86_64,
> > > for which these settings just happen to be the same.
> > 
> > If configure does not realize we are cross-compiling, we are doing
> > something wrong. If it does, it will likely end up with the correct
> > figures for the target, not the build host.
> 
> Makes sense, but why take chances when we know that the above are the
> correct settings for the target?

Oh, apparently we need to be doing this because autoconfig.h contains
more things than just the ARCH_* settings.  But this still feels like
unnecessary risk to me.  When using one of the existing arch-specific .h
files, maybe we could have the ARCH_* settings skipped from autoconfig.h
and use the hardcoded ones?

Alexander

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.