Openwall GNU/*/Linux - a small security-enhanced Linux distro for servers
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Wed, 11 Mar 2015 19:24:45 +0100
From: Frank Dittrich <frank.dittrich@...lbox.org>
To: john-dev@...ts.openwall.com
Subject: Re: john-jumbo bug

Hi Lei,

On 03/11/2015 07:12 PM, 张 磊 wrote:
> Hi,
> 
> There’s seems to be a bug in file mssql12_fmt_plug.c (john-jumbo).
> 
> The variable ‘max_keys’ gets defined in line 107, if the macro ‘MMX_COEF_SHA512’ is predefined.
> But the use of ‘max_key’ in line 186 doesn’t check if ‘MMX_COEF_SHA512’ is predefined. So variable ‘max_keys’ might be undefined here.

What is the latest bleeding-jumbo commit, and what local changes do you
have in your repository?

In my local repository, the latest commit is
f6af7d71df255c87fafb4cb9a7d46886e9f7369a.

This is line 109 of mssql12_fmt_plug.c:
static int max_keys;

This is line 171:
	max_keys = self->params.max_keys_per_crypt;

Both are inside
#ifdef MMX_COEF_SHA512
...
#endif

There is no other use of max_keys, and no use of max_key.
Please check and clarify.

Frank

Powered by blists - more mailing lists

Your e-mail address:

Powered by Openwall GNU/*/Linux - Powered by OpenVZ