[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Tue, 07 Jan 2014 02:45:09 +0100
From: magnum <john.magnum@...hmail.com>
To: john-dev@...ts.openwall.com
Subject: Re: CUDA multi-device support
Cool, thanks. The pull request was not correct but the commits were
almost OK so I cherry-picked them and fixed a slight problem (reverting
a recent patch by Frank).
Now d96d52a in my repo contains your code. Before doing more work,
please reset --hard to that commit (you might need to add a remote for
that), or just delete your fork and make a new one.
The next step would be to change cuda_pwsafe_fmt.c so it uses the new
stuff instead of the hard-coded "GPUS" in cuda_pwsafe.h, if you like.
Beware of the "#ifdef GPUS" in cuda/pwsafe.cu - it must be changed to
runtime decisions.
magnum
On 2014-01-06 17:35, Muhammad Junaid Muzammil wrote:
> Thanks, I have made a pull request against issue # 435.
>
> Regards,
> Junaid
>
>
> On Sun, Jan 5, 2014 at 9:49 PM, magnum <john.magnum@...hmail.com> wrote:
>
>> You need to create your own account on GitHub, fork my repo and push your
>> commit to *your* bleeding-jumbo branch. Then you make a pull request
>> against my repo.
>>
>> https://help.github.com/articles/using-pull-requests
>>
>> magnum
>>
>>
>> On 2014-01-05 17:16, Muhammad Junaid Muzammil wrote:
>>
>>> Hello,
>>>
>>> I was attempting to commit my current changes to git repo but I failed to
>>> do so. Attempting to commit changes over HTTPS gave me HTTP 403 error.
>>>
>>> error: The requested URL returned error: 403 while accessing
>>> https://github.com/magnumripper/JohnTheRipper.git/info/refs
>>> fatal: HTTP request failed
>>>
>>> Changing the URL to ssh gave me an Permission denied (publickey) error.
>>>
>>> Regards,
>>> Junaid
>>>
>>>
>>> On Tue, Dec 31, 2013 at 11:52 PM, Muhammad Junaid Muzammil <
>>> mjunaidmuzammil@...il.com> wrote:
>>>
>>> Sure I'll commit it to the git repo in a couple of days.
>>>>
>>>> Junaid.
>>>>
>>>>
>>>> On Monday, December 30, 2013, magnum wrote:
>>>>
>>>> On 2013-12-29 16:52, Muhammad Junaid Muzammil wrote:
>>>>>
>>>>> Hello,
>>>>>>
>>>>>> I have added multi CUDA device option parsing
>>>>>>
>>>>>>
>>>>> That sounds excellent! Is your code available somewhere yet? Or could
>>>>> you
>>>>> post a patch? I prefer pull requests on GitHub but a patch posted here
>>>>> is
>>>>> fine too, especially if it's not your final cut but more of a RFC.
>>>>>
>>>>> to option.c and cu_common.h.
>>>>>
>>>>>>
>>>>>>
>>>>> We might eventually want to move some of it from options.c to
>>>>> common-cuda.c for various reasons but that is not a problem. Please post
>>>>> your current code for review. Don't forget licensing:
>>>>> http://openwall.info/wiki/john/licensing
>>>>>
>>>>> Currently, I am parsing at most 2 CUDA devices.
>>>>>
>>>>>>
>>>>>>
>>>>> For OpenCL we have a macro MAXGPUS in common-opencl.h, I think it would
>>>>> be nice if you do something similar - in case you didn't already - eg.
>>>>> define MAX_CUDA_DEVICES in cuda_common.h. Perhaps we should default to 8
>>>>> like OpenCL does.
>>>>>
>>>>> I haven't written the test cases for this functionality yet. I
>>>>> couldn't
>>>>>
>>>>>> find any documentation pertaining to unit tests. Is there any such
>>>>>> documentation?
>>>>>>
>>>>>>
>>>>> For the Test Suite? Unfortunately there's not much docs, if any. And the
>>>>> TS mostly just tests formats right now, not things like modes,
>>>>> node/fork or
>>>>> multiple GPUs. It would be nice to add stuff like that but there's a
>>>>> lot of
>>>>> planning and decisions needed.
>>>>>
>>>>> However, there is a pass-through option in TS which just passes options
>>>>> on to john, so you can run a test like this:
>>>>>
>>>>> cd test
>>>>> ./jtrts.pl pwsafe-cuda -passthru="-dev=0,1"
>>>>>
>>>>> magnum
>>>>>
>>>>>
>>>>>
>>>
>>
>>
>
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
