Openwall GNU/*/Linux - a small security-enhanced Linux distro for servers
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Mon, 23 Sep 2013 01:23:28 +0200
From: magnum <john.magnum@...hmail.com>
To: john-dev@...ts.openwall.com
Subject: Re: Daniel's reports #13, #14

On 23 sep 2013, at 00:38, Dániel Bali <balijanosdaniel@...il.com> wrote:
> 2013/9/21 Solar Designer <solar@...nwall.com>
>> After a couple of minutes of staring at your code^Whack, I think I see
>> the bug: you set BINARY_SIZE to 2, whereas it should be 4 (or even 8, if
>> you're for some totally weird reason experimenting with 64-bit hash
>> values for now, even though CRC-32 will only use 32-bit).
> 
> BINARY_SIZE started out as 4, when I was testing and didn't modify everything from the keccak format. 
> But I believe in the end the BINARY_SIZE should be 1, because a CRC32 is 32-bit.
> For example raw-md5-opencl has:
> 
> #define CIPHERTEXT_LENGTH   32
> #define DIGEST_SIZE         16
> #define BINARY_SIZE         4

Yes but raw-md5 use reduced binary and then checks the rest in cmp_exact(). The real binary size in raw-md5 is 16. The binary size have to use for CRC32 is 4, for 32 bits.

magnum

Powered by blists - more mailing lists

Your e-mail address:

Powered by Openwall GNU/*/Linux - Powered by OpenVZ