Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Sat, 18 May 2013 21:43:02 +0200
From: magnum <john.magnum@...hmail.com>
To: john-dev@...ts.openwall.com
Subject: Re: Incremental mode in 1.7.9.14

On 18 May, 2013, at 18:49 , Solar Designer <solar@...nwall.com> wrote:
> magnum, Bartavelle -
> 
> Thank you for your testing of the new incremental mode.  I did some
> testing and tweaking of my own, too.  Here's the single most important fix:
> 
> --- charset.c.orig	2013-04-27 03:36:41 +0400
> +++ charset.c	2013-05-18 20:38:53 +0400
> @@ -581,7 +581,7 @@
> 				double tmp = 0.0;
> 				for (j = 0; j <= counts[length][i]; j++)
> 					tmp += (*cracks)[length][i][j];
> -				for (j = 0; j < CHARSET_SIZE; j++)
> +				for (j = 0; j <= count; j++)
> 					sum += (*cracks)[length][i][j];
> 				if (sum)
> 					tmp /= sum;
> 
> Can you give this a try, please?  It gives very good results for me, but
> more testing (and tweaking of other parameters as well) is needed.

I am on the road, I can hopefully test within 24h. Was this a bug? What is "count" in this context?

magnum

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.