[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Thu, 16 May 2013 13:52:18 +0200
From: magnum <john.magnum@...hmail.com>
To: john-dev@...ts.openwall.com
Subject: Re: missing parentheses in dynamic_fmt.c
On 16 May, 2013, at 13:04 , Jeremi Gosney <epixoip@...dshell.nl> wrote:
> On 05/16/2013 03:39 AM, magnum wrote:
>> On 16 May, 2013, at 11:46 , Jeremi Gosney <epixoip@...dshell.nl> wrote:
>>> dynamic_fmt.c is missing a right parentheses on line 697 that prevents
>>> it from compiling on big endian.
>>>
>>> #if !ARCH_LITTLE_ENDIAN
>>> - memset(input_buf_X86, 0, FLAT_INP_BUF_SZ;
>>> + memset(input_buf_X86, 0, FLAT_INP_BUF_SZ);
>>> #endif
>>>
>> Committed, thank you. Does it pass a "-t=0 -form=dynamic" on BE after this fix?
>>
>> magnum
>
> All formats except dynamic_1300 pass their self-tests, which IIRC is a known issue.
Thanks. Dynamic_1300 was fixed in 19992ec, 4 days ago but Jim probably hasn't tried it on BE yet. I'll create an issue on GitHub.
Oh, I see now it doesn't work with a -generic build on x86 either. So it's not an endian problem.
magnum
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
