[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Mon, 13 May 2013 19:19:59 +0200
From: magnum <john.magnum@...hmail.com>
To: john-dev@...ts.openwall.com
Subject: stderr handling in bash completion & Test Suite (was: Dyna and OpenSSL <1.0.0)
On 13 May, 2013, at 9:21 , Frank Dittrich <frank_dittrich@...mail.com> wrote:
> On 05/13/2013 09:07 AM, Frank Dittrich wrote:
>> You also get that error during bash completion (for every [tab] that
>> results in a "./john --list=subformats" being executed:
>>
> [...]
>> Should stderr be redirected to /dev/null (in line 300 of
>> john.bash_completion (unstable)?
I can't think of any drawbacks. Even if this Whirlpool issue is mitigated, we probably still want to do it.
> Looking at the test suite, I realized:
>
> 1. that the same error occurs here (because stderr is redirected to
> stdout).
>
> 2. that john.bash_completion (similar to jtrts.pl) uses --subformat=LIST
> as a fallback if --list=subformats is not implemented in the current
> john version.
> So, line 303 of john.bash_completion also needs that redirection of stderr.
>
> And these are the lines that need to be changed in the test suite:
>
> $ grep -n ">JohnDynaUsage.Scr" jtrts.pl
> 369: system ("$JOHN_EXE --list=subformats >JohnDynaUsage.Scr 2>&1");
> 372: system ("$JOHN_EXE --subformat=LIST >JohnDynaUsage.Scr 2>&1");
I'll look into this, in bleeding.
magnum
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
