Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date: Sun, 12 May 2013 23:12:52 +0200
From: magnum <john.magnum@...hmail.com>
To: john-dev@...ts.openwall.com
Subject: Re: Unused global symbols in jumbo

For now, I hand-edited the file just like you did, and committed it.

magnum


On 12 May, 2013, at 23:07 , magnum <john.magnum@...hmail.com> wrote:

> That's odd, why did that label suddenly appear? This will be a bit tricky to work around safely. I suppose sse2i_winfix.pl needs to find any labels containing "..", and replace that (not with a macro) with "__" - two underscores to reduce risk for collisions. But there will still be a risk. Then, a matching underscore macro.
> 
> magnum
> 
> 
> On 12 May, 2013, at 2:11 , <jfoug@....net> wrote:
> 
>> Within sse-intrinsics-32.S there are problems:
>> 
>> sse-intrinsics-32.S:8:19: warning: missing whitespace after the macro name
>> sse-intrinsics-32.S:8:0: warning: "SSEmd5body" redefined
>> sse-intrinsics-32.S:7:0: note: this is the location of the previous definition
>> sse-intrinsics-32.S: Assembler messages:
>> sse-intrinsics-32.S:22: Error: junk at end of line, first unrecognized character is `_'
>> sse-intrinsics-32.S:23: Error: unknown pseudo-op: `..0'
>> sse-intrinsics-32.S:3075: Error: unknown pseudo-op: `..0'
>> sse-intrinsics-32.S:11818: Error: junk `_SSEmd5body..0 ..0' after expression
>> Makefile:2295: recipe for target `sse-intrinsics-32.o' failed
>> 
>> these all fail due to the external name:  SSEmd5body..0  I have made hand edits, to change this to SSEmd5body_0, and things build just fine.   Looks like the sse-win32.pl script will need to address this new 'external'.
>> 
>> Jim.
>> 
>> ---- magnum <john.magnum@...hmail.com> wrote: 
>>> On 11 May, 2013, at 19:24 , magnum <john.magnum@...hmail.com> wrote:
>>>> I made the MD5crypt helper functions in sse-intrinsics.c static, which made no difference in itself. So I also added MAYBE_INLINE. There was a 1-2% boost from that here.
>>> 
>>> New intrinsics .S files built and committed. Even better boost, 4-5%.
>>> 
>>> magnum
>>> 
>>> 
>>> 
>> 
> 
> 
> 


Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.