Openwall GNU/*/Linux - a small security-enhanced Linux distro for servers
[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Date: Sat, 11 May 2013 19:55:25 +0400
From: Alexander Cherepanov <cherepan@...me.ru>
To: john-dev@...ts.openwall.com
Subject: Unused global symbols in core

Hi, Solar!

There are unused global symbols in JtR. Here is the analysis for the core:

1. Easy to fix:
crk_remove_hash                 cracker.o <- cracker.c:135

2. Easy to fix:
DES_KS_table                    DES_std.o

3. Not used but supposed to be used (described in .h)?
itoa64                          common.o <- common.c:11

4. Not used but supposed to be used (described in .h)?
fmt_default_valid               formats.o <- formats.c:257
fmt_default_binary              formats.o <- formats.c:267

5. The following are described in rules.h but should they really be 
exported?
rules_errno                     rules.o
rules_line                      rules.o
rules_errors                    rules.o <- rules.c:20
rules_check                     rules.o <- rules.c:959

6. Not used in JtR itself but used in best.c:
benchmark_cps                   bench.o <- bench.c:211
benchmark_format                bench.o <- bench.c:87

7. Ok, the following should be non-static:-)
main                            john.o <- john.c:649

Attached are patches for the first 5 cases (selftests passed). First 
seems to be a sure target, but it's harder to tell for others -- maybe 
they are supposed to be that way.

-- 
Alexander Cherepanov

View attachment "0001-Make-crk_remove_hash-in-cracker.c-static.patch" of type "text/x-patch" (765 bytes)

View attachment "0002-Make-DES_KS_table-in-DES_std.c-static.patch" of type "text/x-patch" (894 bytes)

View attachment "0003-Make-itoa64-in-common.c-static.patch" of type "text/x-patch" (957 bytes)

View attachment "0004-Comment-out-fmt_default_valid-and-fmt_default_binary.patch" of type "text/x-patch" (1776 bytes)

View attachment "0005-Don-t-export-various-symbols-in-rules.-ch.patch" of type "text/x-patch" (2589 bytes)

Powered by blists - more mailing lists

Your e-mail address:

Powered by Openwall GNU/*/Linux - Powered by OpenVZ