[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Tue, 7 May 2013 04:28:07 +0400
From: Solar Designer <solar@...nwall.com>
To: john-dev@...ts.openwall.com
Subject: Re: OMP fallback for non-systemwide build
On Tue, May 07, 2013 at 01:30:09AM +0200, magnum wrote:
> +#ifdef JOHN_SYSTEMWIDE_EXEC
> #define OMP_FALLBACK_PATHNAME JOHN_SYSTEMWIDE_EXEC "/" OMP_FALLBACK_BINARY
> execv(OMP_FALLBACK_PATHNAME, argv);
> +#else
> +#define OMP_FALLBACK_PATHNAME "$JOHN/" OMP_FALLBACK_BINARY
> + execv(path_expand(OMP_FALLBACK_PATHNAME), argv);
> +#endif
What's the intended use for this? Are we (or someone) going to
distribute binary builds that are installable into a user's home
directory, yet want to include the fallback feature? Well, maybe.
However, then we'd want it for CPU fallbacks too, not just OpenMP.
> It does work like a champ. Could that relocation of path_init() pose a problem?
Hopefully not, but I am not sure. We'd need to relocate it even further
up - to before CPU_detect_or_fallback() - then enhance that function,
and test the resulting builds.
Alexander
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
