Openwall GNU/*/Linux - a small security-enhanced Linux distro for servers
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Mon, 6 May 2013 06:34:35 +0400
From: Solar Designer <solar@...nwall.com>
To: john-dev@...ts.openwall.com
Subject: Re: Core: build warning

On Mon, May 06, 2013 at 05:34:36AM +0400, Alexander Cherepanov wrote:
> Solar, some other warnings (from -std=c89 -pedantic) you could be 
> interested in:

Thanks!

> options.c: In function ?print_usage?:
> options.c:115: warning: string length ?1463? is greater than the length 
> ?509? ISO C90 compilers are required to support
> options.c:117: warning: string length ?1463? is greater than the length 
> ?509? ISO C90 compilers are required to support
> options.c:117: warning: string length ?1463? is greater than the length 
> ?509? ISO C90 compilers are required to support

I'm going to ignore these.  I've never seen the long string cause any
problem on any compiler I ever used to build JtR.

> status.c: In function ?status_print_cracking?:
> status.c:202: warning: initializer element is not computable at load time

Fixed.

> trip_fmt.c: In function ?get_hash_0?:
> trip_fmt.c:265: warning: ISO C90 forbids mixed declarations and code
> trip_fmt.c: In function ?get_hash_1?:
> trip_fmt.c:266: warning: ISO C90 forbids mixed declarations and code
> trip_fmt.c: In function ?get_hash_2?:
> trip_fmt.c:267: warning: ISO C90 forbids mixed declarations and code
> trip_fmt.c: In function ?get_hash_3?:
> trip_fmt.c:268: warning: ISO C90 forbids mixed declarations and code
> trip_fmt.c: In function ?get_hash_4?:
> trip_fmt.c:269: warning: ISO C90 forbids mixed declarations and code
> trip_fmt.c: In function ?get_hash_5?:
> trip_fmt.c:270: warning: ISO C90 forbids mixed declarations and code
> trip_fmt.c: In function ?get_hash_6?:
> trip_fmt.c:271: warning: ISO C90 forbids mixed declarations and code
> trip_fmt.c: In function ?cmp_one?:
> trip_fmt.c:512: warning: ISO C90 forbids mixed declarations and code
> trip_fmt.c: In function ?cmp_exact?:
> trip_fmt.c:520: warning: ISO C90 forbids mixed declarations and code

I think these are spurious (gcc bug?), but I've now worked around them
anyway by swapping the "int ..." and "const int ..." lines.

> Jim, BTW what do you do with compiler.c when you compile in MS Visual 
> Studio? AFAIK it doesn't support computed gotos. Do you convert it to 
> switch?

compiler.c provides fallback code for non-gcc, with no dependency on
computed gotos.  It runs 2-3 times slower, though.

Alexander

Powered by blists - more mailing lists

Your e-mail address:

Powered by Openwall GNU/*/Linux - Powered by OpenVZ