Openwall GNU/*/Linux - a small security-enhanced Linux distro for servers
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Tue, 23 Apr 2013 10:34:31 -0700
From: Tavis Ormandy <taviso@...xchg8b.com>
To: john-dev@...ts.openwall.com
Subject: Re: minor raw-sha1-ng pull request

magnum <john.magnum@...hmail.com> wrote:

> On 21 Apr, 2013, at 1:27 , Solar Designer
> <solar@...nwall.com> wrote:
> > Tavis, magnum -
> > 
> > On Fri, Apr 19, 2013 at 06:25:50PM -0700, Tavis Ormandy wrote:
> > > Thanks for the explanation Magnum, I get similar results! I can
> > > restructure cmp_all so it's also omp safe, I sent you a pull request
> > > for that. It get's anoter 2000K c/s on my machine.
> > 
> > Thanks!
> > 
> > The attached patch replaces the heavy "#pragma omp atomic" with much
> > lighter OpenMP reduction for the bitwise OR.  I've checked the OpenMP
> > 2.5 spec (from 2005) - bitwise OR was already supported in the reduction
> > clause, so I think we're good in terms of portability.
> 
> This is committed. Unstable branch still has the non-OMP version. Should
> we merge these changes to it?
>

Sounds like a good idea to me, do you want a pull request for that?

Tavis.



-- 
-------------------------------------
taviso@...xchg8b.com | pgp encrypted mail preferred
-------------------------------------------------------

Powered by blists - more mailing lists

Your e-mail address:

Powered by Openwall GNU/*/Linux - Powered by OpenVZ