Openwall GNU/*/Linux - a small security-enhanced Linux distro for servers
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Sun, 14 Apr 2013 06:58:30 -0700
From: Jeremi Gosney <epixoip@...dshell.nl>
To: john-dev@...ts.openwall.com
Subject: Re: [patch] sse/xop implementation of raw-sha512

On 4/14/2013 5:39 AM, Solar Designer wrote:
> Since you're working on uint64_t here, "size >> 2" should probably be
> "size >> 3" (or just "size / sizeof(*x)" to keep this line generic).
> Your use of uint64_t here requires that binary be 8-byte aligned, but
> I think you're only ensuring it is 4-byte aligned. I suggest that you
> use uint32_t here.

Good catch, that was the problem. I also caught another issue that
wasn't caught by the self-test and have corrected it as well. New patch
attached.



View attachment "rawSHA512_ng_fmt-2.diff" of type "text/plain" (2728 bytes)

Powered by blists - more mailing lists

Your e-mail address:

Powered by Openwall GNU/*/Linux - Powered by OpenVZ