Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Sun, 7 Apr 2013 11:16:54 -0400
From:  <jfoug@....net>
To: john-dev@...ts.openwall.com
Cc: Solar Designer <solar@...nwall.com>
Subject: Re: Fix for NT format (SSE builds, 32 bit)

---- Solar Designer <solar@...nwall.com> wrote: 
> On Sun, Apr 07, 2013 at 11:03:36AM -0400, jfoug@....net wrote:
> > Here is a fix to the bleeding tree, for the NT format.  It has been failing in crypt_all 
> 
> Thanks!  I think this code will run slightly faster if we correct the
> offset rather than move the mov instruction.

If there is a better way to do it, then by all means, that would be great.  I have limited debug skills within cygwin.  So, I simply googled gcc cdecl calling convention, to try to figure out just wtf could be wrong.

The mov 8(esp), eax  were different than the unstable (which works).  So I figured after the popa, that simply looking 4 bytes past esp was right, and it worked.  But there certainly could be much better ways.  If done before popa, wouldn't it be 0x24+4 ?

Jim.

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.