Openwall GNU/*/Linux - a small security-enhanced Linux distro for servers
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Thu, 14 Mar 2013 22:37:05 +0400
From: Solar Designer <solar@...nwall.com>
To: john-dev@...ts.openwall.com
Subject: Re: clock err in timers (alarm, status ...) and fix

On Thu, Mar 14, 2013 at 05:40:53PM +0100, magnum wrote:
> I applied Costin's changes almost verbatim. Is that not good enough?

The patch looked buggy to me at first glance (where are the timer_*
variables initialized in accordance with their new meaning? nowhere?
is the re-initialization via the first += good enough?), but it might
actually be OK.  What type are those variables, though?  Anyhow, if
they're at least 32-bit and we're talking seconds, the wraparound won't
occur before 2038.

Overall, I'd be happier if jumbo only touched the aspects related to its
added features, not changed core features for no or little reason.

Calling status_get_time() every second is a bit wasteful.  Perhaps only
do that when auto-status or auto-abort is requested?

Perhaps not bother with that for auto-save?  Or only bother with it for
auto-save when OS_TIMER is 0 (that is, when the signal handler
invocation frequency is expected to be very rather than just slightly
imprecise)?

Alexander

Powered by blists - more mailing lists

Your e-mail address:

Powered by Openwall GNU/*/Linux - Powered by OpenVZ