Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Tue, 22 Jan 2013 00:30:10 +0100
From: magnum <john.magnum@...hmail.com>
To: john-dev@...ts.openwall.com
Subject: Re: How to use SHA-2 in JtR code

On 21 Jan, 2013, at 22:46 , "jfoug" <jfoug@....net> wrote:
> However, this is by itself, not perfect.  I looked at mscash2_fmt_plug.c
> (since I have had my hands all over that one).  Here is the code:
> 
> #ifndef HAVE_OPENSSL
> #include "sha.h"
> #include "md4.h"
> #else
> #include <openssl/sha.h>
> #include <openssl/md4.h>
> #endif
> 
> So this one does have some #define 'magic' within the C file. However, this
> one should be changed to simply be:
> 
> #include "sha.h"
> #include "md4.h"

HAVE_OPENSSL is never ever set unless you manually put it in somewhere. Is that an artefact from some ancient Jumbo version, or is it for debugging and/or benchmarking? Whatever the answer, your statement about mscash2 is true of course.

magnum

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.