[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Date: Sun, 20 Jan 2013 11:54:27 +0100
From: magnum <john.magnum@...hmail.com>
To: "john-dev@...ts.openwall.com" <john-dev@...ts.openwall.com>
Subject: More self-tests added
I committed the following to unstable now:
"Add self-tests that fail if you have a binary size > 0 but are using fmt_default_binary() - and a similar test for salt. I believe this does not emit any false positives but I'm not 100% sure yet."
It hits 12 formats (not counting GPU ones), most are Dhiru's. Very easy fixes, just reset the size in question to 0 (after verifying this is a correct fix).
For a format that does not use salt, you should obviously report a SALT_SIZE of 0, and for non-hash "salt only" formats, you should report a BINARY_SIZE of 0.
If you find any false positive or otherwise think this is flawed, please complain. I think the binary case might theoretically produce false positives for some non-existing format, but I believe the current ones that fail are actually bugs.
magnum
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
