john-dev - Re: lastpass valid()

Follow @Openwall on Twitter for new release announcements and other news

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Fri, 18 Jan 2013 00:12:34 +0100
From: magnum <john.magnum@...hmail.com>
To: john-dev@...ts.openwall.com
Subject: Re: lastpass valid()

On 17 Jan, 2013, at 21:10 , magnum <john.magnum@...hmail.com> wrote:
> Dhiru,
> 
> Even your very latest format, lastpass, segfaults from the valid-killer self-test. Not sure why, it seems to have a fairly decent valid().

Forget it, I fixed it.

@@ -85,6 +85,7 @@ static int valid(char *ciphertext, struct fmt_main *self)
        if ((p = strtok(ctcopy, "$")) == NULL)  /* email */
                goto err;
        if ((p = strtok(NULL, "*")) == NULL)    /* hash */
+               goto err;
        if (strlen(p) != 32)
                goto err;
        if (!ishex(p))


This kind of changes the behavior :-)

magnum

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.