Openwall GNU/*/Linux - a small security-enhanced Linux distro for servers
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Sat, 5 Jan 2013 01:10:43 +0100
From: magnum <john.magnum@...hmail.com>
To: john-dev@...ts.openwall.com
Subject: New plugin load order magic (was: A few questions regarding the newly added BLAKE2 format)

On 1 Jan, 2013, at 23:30 , Frank Dittrich <frank_dittrich@...mail.com> wrote:
> On 01/01/2013 10:48 PM, magnum wrote:
>> What we could do if you insist, is force raw-sha512 to load before blake.
> I do not insist. I am just unsure what the best solution is.
> Knowing what formats *could* possibly crack a given hash also is an
> important feature.
> May be you are right, and it is more important to let the user know that
> there are possibly more formats which could crack a given hash than
> allowing him not to specify --format=, and still expect a raw hash to be
> treated as raw-sha512.
> 
>> Either by renaming one of the source files so the plugin globbing will put them in a different order, or by making raw-sha512 a non-plugin.
> 
> No, spending/causing effort for such crude workarounds is not what I
> wanted, although, in this particular case it might be a bit unfortunate
> that BLAKE2 would grab raw-sha512 hastes, even if BLAKE2 probably isn't
> really used as a password hash function.
> There might be users who will complain on john-users when they are not
> longer able to crack raw-sha512 hashes if they forget the --format switch.
> 
> May be this really should have been discussed on john-users as well, so
> tomorrow I'll try to get this discussed on john-users.

After Lukas' struct name fixes, I opted to try the struct-name sort order, committed now. I took the chance to rename fmt_rawSHA512 to fmt_raw0_SHA512 which ensures it loads before the Blake2 format. BTW I also renamed (talking format *labels* now) blake2-512 to raw-blake2-512, I hope anyone doesn't disagree with that?

Some review of fmt_registers.h did not reveal any other cases I should fix. The MSSQL formats are in correct order, as is the NETLM ones, raw-sha1, NT and .

Here is the old load order:
(des, bsdi, md5, bf, afs, lm, dynamic_n)
bfegg, dmd5, dominosec, epi, fortigate, hdaa, ipb2, krb4, krb5, mschapv2, 
netlm, netlmv2, netntlm, netntlmv2, nethalflm, md5ns, nt, phps, po, 
sybasease, xsha512, xsha, chap, clipperz, crc32, sha256crypt, sha512crypt, 
dmg, dragonfly3-32, dragonfly3-64, dragonfly4-32, dragonfly4-64, drupal7, 
encfs, episerver, formspring, gost, gpg, hmac-sha224, hmac-sha256, 
hmac-sha384, hmac-sha512, hmailserver, ike, keepass, keychain, keyring, 
krb5pa-md5, krb5pa-sha1, lp, lastpass, lotus5, md4-gen, mediawiki, mongodb, 
mscash, mscash2, mssql, mssql05, mssql12, mysql-sha1, mysql, mysqlna, npdf, 
nsldap, nt2, nk, o5logon, odf, office, oldoffice, oracle11, oracle, osc, 
pbkdf2-hmac-sha512, phpass, pix-md5, pkzip, postgre, pst, putty, pwsafe, 
racf, radmin, blake2-512, raw-md4, raw-md5, raw-sha1, raw-sha1-linkedin, 
raw-sha224, raw-sha256, raw-sha384, raw-sha512, raw-md5u, salted-sha1, sapb, 
sapg, sha1-gen, sip, ssh-ng, strip, sunmd5, sxc, openvms, vnc, wbb3, wowsrp
(hmac-md5, hmac-sha1, raw-sha, django, tc_ripemd160, tc_sha512, tc_whirlpool,
raw-sha1-ng, crypt, trip, ssh, pfx, pdf, wpapsk, rar, zip, dummy)

Here is the new one:
(des, bsdi, md5, bf, afs, lm, dynamic_n, bfegg)
dmd5, dominosec, epi, fortigate, formspring, hdaa, ipb2, krb4, krb5, 
keepass, mschapv2, mysql, nethalflm, netlm, netlmv2, netntlm, netntlmv2, 
md5ns, nt, nt2, osc, phps, po, sybasease, openvms, xsha, xsha512, wowsrp, 
chap, clipperz, crc32, sha256crypt, sha512crypt, dmg, dragonfly3-32, 
dragonfly3-64, dragonfly4-32, dragonfly4-64, drupal7, encfs, episerver, 
gost, gpg, hmac-sha224, hmac-sha256, hmac-sha384, hmac-sha512, hmailserver, 
ike, keychain, keyring, krb5pa-sha1, lp, lotus5, md4-gen, mediawiki, 
mongodb, mscash, mscash2, krb5pa-md5, mssql, mssql05, mssql12, mysql-sha1, 
mysqlna, nk, npdf, nsldap, o5logon, odf, office, oldoffice, oracle, 
oracle11, pbkdf2-hmac-sha512, phpass, pix-md5, pkzip, postgre, pst, putty, 
pwsafe, racf, radmin, raw-sha512, raw-blake2-512, raw-md4, raw-md5, 
raw-sha1, raw-sha1-linkedin, raw-sha224, raw-sha256, raw-sha384, raw-md5u, 
salted-sha1, sapb, sapg, sha1-gen, sip, lastpass, ssh-ng, strip, sunmd5, 
sxc, vnc, wbb3, hmac-md5
(hmac-sha1, raw-sha, django, tc_ripemd160, tc_sha512, tc_whirlpool, 
raw-sha1-ng, crypt, trip, ssh, pfx, pdf, wpapsk, rar, zip, dummy)

Please test/review/comment.

magnum

Powered by blists - more mailing lists

Your e-mail address:

Powered by Openwall GNU/*/Linux - Powered by OpenVZ