john-dev - non-OMP build failure

Openwall GNU/*/Linux - a small security-enhanced Linux distro for servers

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date: Sun, 30 Dec 2012 10:12:01 +0530
From: Dhiru Kholia <dhiru.kholia@...il.com>
To: john-dev@...ts.openwall.com
Subject: non-OMP build failure

Hi,

I can't build unstable jumbo in non-OMP mode.

$ git rev-parse HEAD
b15beb1c0d5f75e98be1ca07b16a6f30b9754f59

$ make linux-x86-64
sapG_fmt_plug.c: In function ‘clear_keys’:
sapG_fmt_plug.c:243:38: error: ‘omp_t’ undeclared (first use in this function)

Following patch seems to fix this problem and works OK,

diff --git a/src/sapG_fmt_plug.c b/src/sapG_fmt_plug.c
index c57de23..58da838 100644
--- a/src/sapG_fmt_plug.c
+++ b/src/sapG_fmt_plug.c
@@ -38,9 +38,10 @@

 #define ALGORITHM_NAME                 SHA1_ALGORITHM_NAME

+static unsigned int omp_t = 1;
+
 #if defined(_OPENMP) && (defined (SHA1_SSE_PARA) || !defined(MMX_COEF))
 #include <omp.h>
-static unsigned int omp_t = 1;
 #ifdef SHA1_SSE_PARA
 #define OMP_SCALE                      128
 #else

-- 
Cheers,
Dhiru