[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Date: Thu, 27 Dec 2012 17:33:41 +0100
From: Frank Dittrich <frank_dittrich@...mail.com>
To: john-dev@...ts.openwall.com
Subject: Commit cf940c5a broke "make generic" on 64bit Linux system
Hi magnum,
The following commit broke "make clean; make generic" on my 64bit Linux
system.
When trying to build the bench binary, gcc complains about the undefined
reference to options in function sig_handle_timer (signals.o).
For some reason, I have no such problems on my 32bit Linux system.
I tried to change the Makefile (add options.o to the BENCH_OBJS list),
but it looks like I'll end up with all the other object files as new
dependencies, so I gave up at some point (when I needed to add
dynamic_fmt.o, IIRC).
An easier, but IMHO a somewhat ugly fix might be to change bench.c:
--- a/src/bench.c
+++ b/src/bench.c
@@ -44,8 +44,9 @@
#include "formats.h"
#include "bench.h"
-#ifndef _JOHN_BENCH_TMP
#include "options.h"
+#ifdef _JOHN_BENCH_TMP
+struct options_main_options;
#endif
#ifdef HAVE_MPI
But I do not yet understand why the current code works on 32bit Linux,
but not on 64bit Linux.
Frank
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
